Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cheriot] CSetBoundsRoundDown instruction and intrinsic #48

Open
wants to merge 1 commit into
base: cheriot
Choose a base branch
from

Conversation

nwf
Copy link
Member

@nwf nwf commented Nov 19, 2024

No description provided.

@v01dXYZ
Copy link

v01dXYZ commented Nov 19, 2024

Hello,
Where are the tests for both llvm intrinsics and clang intrinsics ? If it is an easy task (for some of them), I am voluntary to do it.

@resistor
Copy link
Collaborator

Hello, Where are the tests for both llvm intrinsics and clang intrinsics ? If it is an easy task (for some of them), I am voluntary to do it.

Hi, are you still interested in this? I think this should be a pretty self contained piece of work that would be great for ramping up on. If not, I can take it over.

@resistor resistor self-requested a review December 10, 2024 22:33
@v01dXYZ
Copy link

v01dXYZ commented Dec 12, 2024

I'll do it. Do you want me to do it for this intrinsic first or to try to ît for many of them (mabe not all at first) at once ?

@resistor
Copy link
Collaborator

I would start with just this one.

@davidchisnall davidchisnall deleted the branch CHERIoT-Platform:cheriot December 12, 2024 10:03
@davidchisnall
Copy link

I think we have tests for the others already?

@davidchisnall davidchisnall reopened this Dec 12, 2024
@nwf nwf force-pushed the 202411-csetboundsrounddown branch from 445c627 to eb05e95 Compare December 12, 2024 17:41
@v01dXYZ
Copy link

v01dXYZ commented Dec 17, 2024

@nwf I added some tests for the LLVM parts (CodeGen, MC). v01dXYZ@e7c0231

Is there any reasons why this intrinsic is not available with Mips ?

@davidchisnall You're right. The other ones are already present.

@nwf
Copy link
Member Author

nwf commented Dec 18, 2024

@nwf

Thanks a lot!

Is there any reasons why this intrinsic is not available with Mips ?

The instruction has yet to be specified for CHERI-MIPS and, since that platform's long been sent to enjoy a farm in the countryside, I can't imagine it will be. Similarly, it's not specified for CHERI-RISC-V or the in-progress RISC-V Zcheripurecap and adjacent constellation of standards, though I think we are likely to define it (again) for CHERIoT v2 (which will be atop Zcheripurecap and friends).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants