-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 5: Grace Gilbert #45
Open
gracelgilbert
wants to merge
36
commits into
CIS565-Fall-2019:master
Choose a base branch
from
gracelgilbert:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracelgilbert
commented
Oct 29, 2019
- Repo Link
- Features
- DirectX Raytracing CPU setup
- Ray generation
- Shadows and reflections
- Multiple procedural sphere intersection
- Volumetric Metaball intersection
- Phong lighting, Schlick's approximation for Fresnel reflection
- Distance falloff
- Performance analysis
- I feel like I had a very high level understanding of how the DirectX pipeline worked, but had trouble figuring out where and how all of that happens in the code. I found myself trying out different values in certain functions rather than actually understanding what the changes I was making actually were doing. I think a little more background on the implementation details would be helpful to make the CPU setup part of the project more approachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.