Comment out non error/exception messages #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Thanks! I opened #9 as an enhancement to support a user-provided callback function for logging at various log levels (using whatever the client's logging framework of choice happens to be). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these messages being output during normal processing. longer term it might be nice to be able to configure the library with a log level and dynamically include messages.
In my case, our service is started by systemd and these messages were filling up the journal. I didn't want to suppress stdout nor did i want to send these messages to a separate file so it was easiest to just comment them out - thought you may want to do the same