-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 64-bit support #36
Conversation
Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
I doubt anyone will run the 32-bit version over the new 64-bit version, so you can purge |
Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
Metamod:Source and SourceMod 1.11 (stable) don't have support for this yet and won't load, so I think most people won't switch to x64 yet. SM 1.12 (dev) does load when I try, but extensions like DHooks (issue here) are missing, which breaks a lot of TF2 plugins. I added a check to ensure x64 only gets enabled if using the base image and Without plugins the server starts and works without errors, tested all tags to confirm. |
Good point, I forgot about sourcemod and metamod. Given the architecture problems, it might be warranted to split the dockerfile and setup a multi-platform build. I might be able to do that this weekend. |
Signed-off-by: Kirin Etheridge <[email protected]>
I tried to split them with the kir68k@3c135bf commit, although I'm not sure what should be done in docker build --target=bookworm-base -f $(basename ${DOCKERFILE_PATH}) -t $DOCKER_REPO:latest-x64 -t $DOCKER_REPO:base ${BUILD_PATH}.
docker build --target=bookworm-metamod -f $(basename ${DOCKERFILE_PATH}) -t $DOCKER_REPO:metamod-x64 ${BUILD_PATH}.
docker build --target=bookworm-sourcemod -f $(basename ${DOCKERFILE_PATH}) -t $DOCKER_REPO:sourcemod-x64 ${BUILD_PATH}. Which is what I used to locally build and test the changes. As I understand, the The "ci/dockercloud-stage" check currently fails due to the service being unavailable, although if it looks for |
Yes, that variable is controlled via docker hub. However, it's quiet silly, it just needs to find a valid Dockerfile and then it just runs what's in |
I'll merge the PR and then the new tags should be available. Thanks for the contribution! |
Valve today published an update adding Vulkan to the client and 64-bit version of the engine on both the client and servers, providing
srcds_run_64
andsrcds_linux64
.I've added an envvar and a way to enable/disable it, which works on my machine, but has issues with existing 32-bit libraries:
There is a
bin/linux64
andtf/bin/linux64
directory with proper 64-bit libraries includingreplay_srv.so
, but I'm not sure if there's a way of using those other thanLD_LIBRARY_PATH
.Making this as a draft until everything is tested and works properly.