-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AoA studies #24
Draft
smsimon
wants to merge
84
commits into
master
Choose a base branch
from
AoA_studies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
AoA studies #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mm pixel with 469 detectors from 5.3 mm pixel with 432 pixels
…ault value is 1 while await updated noises
* add new scripts * Working implementation * Apply correlation factors
… SAT MF focal planes to have different wafer spacings and platescales. Add FOV_cut diameter in tubes to account for not illuminating full focal plane in optics designs.
NET and elevation scalings updated for SAT MF1, MF2. Awaiting updated correlation factors.
Noise updates to SAT MF1/MF2 now complete
@smsimon Any reason we could not merge this PR? |
I've been keeping it separate from the DC1 branch because the instrument configurations are very different. I wanted to see what our path forward after the AoA was before making changes to the DC1 branch since there were some big structural changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the structure for a CHSAT and update the HF layout to be full wafers vs. partial. The noise parameters for the CHSAT will need to be updated once they are available