Skip to content

Commit

Permalink
Merge pull request #7 from CMLabsLLC/verified2
Browse files Browse the repository at this point in the history
Additional Verification Changes
  • Loading branch information
russellbstephens authored Oct 8, 2024
2 parents 0d13ae4 + 7add372 commit fd9c3f6
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 6 deletions.
2 changes: 1 addition & 1 deletion config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": {
"title": "name",
"type": "string",
"required": false,
"required": true,
"default": "Car Lock"
},
"username": {
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "homebridge-subaru",
"displayName": "Homebridge Subaru",
"type": "module",
"version": "0.1.1",
"version": "0.1.2",
"description": "Exposes basic starlink funcationality to homekit",
"author": "Russell Stephens",
"license": "Apache-2.0",
Expand All @@ -17,7 +17,10 @@
"keywords": [
"homebridge-plugin",
"subaru",
"starlink"
"starlink",
"homebridge plugin",
"homebridge subaru",
"homebridge subaru starlink"
],
"main": "dist/index.js",
"engines": {
Expand Down
6 changes: 5 additions & 1 deletion src/subaruHomebridgePlatform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ export class SubaruHomebridgePlatform implements DynamicPlatformPlugin {
this.Service = api.hap.Service;
this.Characteristic = api.hap.Characteristic;

if (!config.name) {
this.log.error('Missing required config value: name');
}

if (!config.username) {
this.log.error('Missing required config value: username');
}
Expand Down Expand Up @@ -83,7 +87,7 @@ export class SubaruHomebridgePlatform implements DynamicPlatformPlugin {

const existingAccessory = this.accessories.find(accessory => accessory.UUID === uuid);

const deviceName = this.config.name || 'Subaru Door Lock';
const deviceName = this.config.name || '';

const device = {
name: deviceName,
Expand Down

0 comments on commit fd9c3f6

Please sign in to comment.