Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB2D-5782 Database changes for AttributionDataShare Lambda #1293

Merged

Conversation

smirnovaae
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/AB2D-5782

🛠 Changes

  • Added create_current_mbi_table.sql liquibase file where I create a new table public.current_mbi and insert unique current mbis from public.coverage table.
  • Added create_current_mbi_procedure.sql liquibase file where I create a procedure to insert values from 2023 partition to public.current_mbi table

ℹ️ Context for reviewers

Performance of the AttributionDataShare Lambda in production will need some kind of persistence. An easy way to do this based on our existing architecture that the engineering team has discussed is by utilizing a database procedure.

✅ Acceptance Validation

Deployed the branch on dev:

Screenshot 2023-11-06 at 12 26 09 PM

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

@smirnovaae smirnovaae requested a review from a team as a code owner November 6, 2023 21:06
@Sadibhatla
Copy link
Contributor

please keep a 2024 included stored proc ready too.. as by the time we actually deploy it , it need to be pulling from 2024 tables .. (so have the script , comment and include in the PR ).. Evrything looks great ..

@smirnovaae smirnovaae merged commit 8ad1104 into master Nov 9, 2023
1 check passed
@smirnovaae smirnovaae deleted the AB2D-5782/Database_changes_for_AttributionDataShare_Lambda branch November 9, 2023 20:01
Sadibhatla added a commit that referenced this pull request Nov 15, 2023
Sadibhatla added a commit that referenced this pull request Nov 15, 2023
…1295)

* Revert "AB2D-5782 Database changes for AttributionDataShare Lambda (#1293)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants