[AB2D-5918] Add Null Attestation Handling #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github actions" This reverts commit 68479e0.
smirnovaae
approved these changes
Jan 29, 2024
Sadibhatla
approved these changes
Jan 29, 2024
worker/src/main/java/gov/cms/ab2d/worker/processor/JobPreProcessorImpl.java
Show resolved
Hide resolved
| @@ -131,12 +132,30 @@ void whenJobIsInSubmittedStatus_ThenJobShouldBePutInProgress() throws Interrupte | |||
| verify(jobRepository).save(Mockito.any()); | |||
| } | |||
|
|
|||
| @DisplayName("Job is FAILED if contract is not attested") | |||
| @Test | |||
There was a problem hiding this comment.
just a few line comments about mock tests also would be great for readability in future. Everything else looks great and Great job on finishing this super quickly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-5908
https://jira.cms.gov/browse/AB2D-5918
🛠 Changes
Adds a Null Check for AttestationDate in JobPreprocessorImpl.
If Null Check Triggers:
Logs a warning to AWS
Updates job to a failed status and updates events job_status_changed table with relevant information.
ℹ️ Context for reviewers
This is to implement a check so we can handle the case where the attestation date of a contract was null in our system and a job was started against that contract and fail the job before it starts.
Alleviates the current issue where the job would be stuck in the submitted status, and our logs on AWS would be bombarded and clogged with NullPointer Exceptions.
✅ Acceptance Validation
This has been deployed to the IMPL environment and tested there:
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.