Jimmyfagan/bb2-3549-Remove feature flag calls from web-server

[JFU-NAVA-PBC]

JIRA Ticket:
BB2-3549

What Does This PR Do?

After rollout of the limit_data_access flag has been completed, we will remove the checks within the web-server repo for the limit_data_access flag. Most of the work will be removing the nested if check, such as:
if self.data_access_type == "ONE_TIME": flag = get_waffle_flag_model().get("limit_data_access") if flag.rollout or (flag.id is not None and flag.is_active_for_user(self.user)):

In the above case, everything after the data access type check would be removed and the following code block would go under the previous if block.

There are also calls within test_data_access_grant.py and test_authorization.py that are

@override_flag('limit_data_access', active=True)

and these would need to be removed.

What Should Reviewers Watch For?

1. Check the source code for any references to to limit_data_access flag is cleaned up including decorators in main code and tests
2. Pass all the tests local and on CI check
3. Check if there is any impact on other components e.g. bfd insights, splunk dashboards

If you're reviewing this PR, please check for these things in particular:

Validation

1. Visual check there is no reference to the flag, main execution paths, tests, mgmt commands
2. Spin up a local instance and check the django admin - the flag is no. longer created as local instance initialization
3. Pass unit tests, also check CI check did not break
4. Check out BFD repo and see if there is any reference (bfd insights scripts) to the flag

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

• Adds any new software dependencies
• Modifies any security controls
• Adds new transmission or storage of data
• Any other changes that could possibly affect security?

• Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
  security engineer's approval.

Any Migrations?

• Yes, there are migrations
  • The migrations should be run PRIOR to the code being deployed
  • The migrations should be run AFTER the code is deployed
  • There is a more complicated migration plan (downtime,
    etc)
• No migrations

[jimmyfagan]

Looks good and tests seem to be passing.