Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3598: Update Dockerfiles to Python 3.11 #1279

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

sb-benohe
Copy link
Contributor

@sb-benohe sb-benohe commented Jan 7, 2025

JIRA Ticket:
BB2-3598

What Does This PR Do?

This PR updates all of our docker files for running selenium tests to python 3.11 this aligns with our python standard version.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@sb-benohe sb-benohe self-assigned this Jan 7, 2025
@sb-benohe sb-benohe added enhancement dependencies Pull requests that update a dependency file labels Jan 7, 2025
@sb-benohe sb-benohe changed the title Update Dockerfiles to Python 3.11 BB2-3598: Update Dockerfiles to Python 3.11 Jan 7, 2025
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sb-benohe sb-benohe merged commit f15a3e5 into master Jan 7, 2025
8 checks passed
@sb-benohe sb-benohe deleted the ben/BB2-3598 branch January 7, 2025 16:44
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually Dockerfiles/Dockerfile.selenium-jenkins and Dockerfile.selenium-jenkins-python311

are no longer used, the latest one is Dockerfile.selenium-jenkins-python311-plus-chromedriver which is removed somehow.

We need to recover Dockerfile.selenium-jenkins-python311-plus-chromedriver and remove others.

Dockerfile.selenium-jenkins-python311-plus-chromedriver is used to build a docker image and upload to ECR for used at CI check time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants