Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jimfuqian/BB2 Recover Dockerfile.selenium-jenkins-python311-plus-chromedriver (for building CI docker iamge) and clean up unused #1280

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Jan 7, 2025

JIRA Ticket:
BB2-XXXX

What Does This PR Do?

For unknown reason, the docker file for building CI docker image (currently at AWS ECR: public.ecr.aws/f5g8o1y9/bb2-cbc-build-selenium-python311-chromium:latest ) become empty and removed by later PR, this PR restore that dockerfile and cleanup other unused to avoid confusion, also updated the readme to document the current manual process of building and pushing the image.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

One way to verify is to go to Jenkins jobs and trigger a CI check with selenium tests
I did one already as shown:

image

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@sb-benohe sb-benohe self-requested a review January 7, 2025 20:50
Copy link
Contributor

@sb-benohe sb-benohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 6ae222f into master Jan 7, 2025
8 checks passed
@JFU-NAVA-PBC JFU-NAVA-PBC deleted the jimfuqian/BB2-recover-the-CI-dockerfile branch January 7, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants