Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course info basic components #16

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

amitmishra11
Copy link

Description

Fixes

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

"cwd": "${workspaceFolder}"
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think pushing this particular folder is necessary

Copy link
Member

@king-11 king-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for formatting @Divyansh013 please add a check for eslint

@king-11
Copy link
Member

king-11 commented Feb 4, 2023

you still have to remove .vscode from staging area after updating .gitignore you have to run some commands.

Refer: https://stackoverflow.com/questions/25436312/gitignore-not-working

@amitmishra11
Copy link
Author

you still have to remove .vscode from staging area after updating .gitignore you have to run some commands.

Refer: https://stackoverflow.com/questions/25436312/gitignore-not-working

Thanks a lot. Now it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants