Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Standardization #89

Closed
wants to merge 2 commits into from
Closed

Color Standardization #89

wants to merge 2 commits into from

Conversation

partik03
Copy link

@partik03 partik03 commented Oct 1, 2022

Description

I have replaced all the the hex code colors with some uniform colors codes declared in the variables.scss file in the assets folder.

This change tries to create the code more uniform and aims to solve an issue

Fixes

Fixes #74 by @king-11

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for cops ready!

Name Link
🔨 Latest commit 897beb2
🔍 Latest deploy log https://app.netlify.com/sites/cops/deploys/6337d88905b7250008b5dbb0
😎 Deploy Preview https://deploy-preview-89--cops.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@IamEzio IamEzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good. However, the deploy preview still shows older version of the landing page. Pull the latest changes from the main branch. This would also solve the unnecessary changes showing up in pnpm-lock.yaml file.

@@ -427,6 +425,7 @@ export default {
z-index: 0;
overflow: hidden;
box-sizing: border-box;
/* background: red; */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line. Ditto below

@@ -183,6 +183,8 @@ export default {
border-color: rgba(0, 0, 0, 0.4);
border-style: solid;
background-size: cover;
background: linear-gradient(90deg, hsla(180, 0%, 41%, 1) 0%, hsla(0, 0%, 0%, 1) 100%);
;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra semicolon.

<span class="control-prev"
v-html="prevHtml"
>
</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Color Standardization
2 participants