-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Standardization #89
Conversation
✅ Deploy Preview for cops ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look good. However, the deploy preview still shows older version of the landing page. Pull the latest changes from the main
branch. This would also solve the unnecessary changes showing up in pnpm-lock.yaml file.
@@ -427,6 +425,7 @@ export default { | |||
z-index: 0; | |||
overflow: hidden; | |||
box-sizing: border-box; | |||
/* background: red; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line. Ditto below
@@ -183,6 +183,8 @@ export default { | |||
border-color: rgba(0, 0, 0, 0.4); | |||
border-style: solid; | |||
background-size: cover; | |||
background: linear-gradient(90deg, hsla(180, 0%, 41%, 1) 0%, hsla(0, 0%, 0%, 1) 100%); | |||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra semicolon.
<span class="control-prev" | ||
v-html="prevHtml" | ||
> | ||
</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation.
Description
I have replaced all the the hex code colors with some uniform colors codes declared in the variables.scss file in the assets folder.
This change tries to create the code more uniform and aims to solve an issue
Fixes
Fixes #74 by @king-11
Types of changes
Checklist: