Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the lighthouse score of blogs's page #112

Closed
wants to merge 1 commit into from

Conversation

yash6318
Copy link
Contributor

@yash6318 yash6318 commented Oct 3, 2022

Description

In this PR:

  • Added my name to members.json
  • Addressed all the issues related to lighthouse improvement of the blog's page:
  1. Added alt attributes to img tag
  2. Heading elements are noe in sequentially-descending order
  3. Resolved the issue of link to a specific blog was not operational for the whole card.
  4. Added some visual enhancement to the cards 🙃

PS: Mistakenly wrote team's page instead of blog's page in the commit 🥲

Fixes

Fixes part of #107 by @somudas

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for cops failed.

Name Link
🔨 Latest commit a4adc97
🔍 Latest deploy log https://app.netlify.com/sites/cops/deploys/633af8f3fff65c00087ce9aa

@yash6318 yash6318 closed this Oct 3, 2022
@yash6318 yash6318 deleted the newbyyash branch October 3, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant