Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved lighthouse score on blog's page #113

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Conversation

yash6318
Copy link
Contributor

@yash6318 yash6318 commented Oct 3, 2022

Description

In this PR:

Addressed all the issues related to lighthouse improvement of the blog's page:

  1. Added alt attributes to img tag.
  2. Heading elements are now in sequentially-descending order.
  3. Resolved the issue of link to a specific blog was not operational for the whole card.
  4. Added some visual enhancement to the cardsfor better visibility 🙃 .
  5. Improved Links do not have discernible names.
  6. Improved CLS to the permitted range(for mobile).

Current Lighthouse:
image


After changes:
image


However there is some drop in the lighthouse score due to 'netlify' in the deployment. These can be ignored (for obvious reason).


PS: I guess there's something wrong in best practices in Lighthouse...yesterday the score of the current site was 83 in that but now showing 100 yet netlify deployment still shows the same i.e. 83. (It's because of the reason that errors logged in the console but i have'nt changed anything related to this in this PR).

Fixes

Fixes part of #107 by @somudas

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for cops ready!

Name Link
🔨 Latest commit 8ce5305
🔍 Latest deploy log https://app.netlify.com/sites/cops/deploys/633c2adc86fe540009243c39
😎 Deploy Preview https://deploy-preview-113--cops.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@IamEzio IamEzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yash6318. However, the issue description states much more that needs to be done in the blogs' page. PTAL

content/members/members.json Outdated Show resolved Hide resolved
@IamEzio IamEzio merged commit c8c7b99 into COPS-IITBHU:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants