Update VISSR (VISS data server) for VISS v3 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawr
added
enhancement
Currently CDSP points at a VISSR commit that implements VISS v2. Since then the upstream VISS community has been working towards VISS v3 and updated the VISSR implementation of it accordingly. Allow CDSP users to experiment with this new work by updating the CDSP git submodule to point at the latest upstream VISSR commit on the master branch. Integration was sanity tested using the VISSR HTML client to get/set VSS data into the Apache IoTDB DB. Signed-off-by: Stephen Lawrence <[email protected]>
slawr
force-pushed
the
update-vissr-59
branch
from
4aa78d6 to
f2f0691
Compare
5 tasks
slawr
changed the title
Extend the documentation site examples page to have links to the upstream VISSR hello-world tutorial and the examples in the VISS specification. Signed-off-by: Stephen Lawrence <[email protected]>
Update the docker readme.md to reflect changes brought about by CDSP now using VISSR v3: 1. VISSR now provides a default binary list of VSS nodes so remove the note about having to generate vss_vissv2.binary 2. VISSR no longer serves a list of the VSS nodes supported at the URL http://<server ip>:8081/vsspathlist. Remove the associated note. Signed-off-by: Stephen Lawrence <[email protected]>
slawr
force-pushed
the
update-vissr-59
branch
from
0ac322b to
0748ae6
Compare
|
Hi @chrizmc I spotted that I had left a piece of debug code in the example documentation so I have just updated the PR to fix it, by force pushing a squashed fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CDSP points at a VISSR commit that implements VISS v2. Since then the upstream VISS community has been working towards VISS v3 and updated the VISSR implementation of it accordingly.
Allow CDSP users to experiment with this new work by updating the CDSP git submodule to point at the latest upstream VISSR commit fbb02dec on the master branch.
Integration was sanity tested using the VISSR HTML client to get/set VSS data into the Apache IoTDB DB.
See task issue #59 for details