Add gtest to Fetch content #550 #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if I should also update github actions |
|
Are there any advantages over using |
|
FetchContent will download Google test automatically so at the end we don't need to manually download that and tell cmake where it is installed |
goncaloalmeida
approved these changes
Nov 10, 2023
goncaloalmeida
approved these changes
Nov 10, 2023
DiogoPedrozza
approved these changes
Nov 10, 2023
goncaloalmeida
pushed a commit
to goncaloalmeida/vsomeip
that referenced
this pull request
Dec 11, 2023
Notes: This reverts commit 70d59ed - breaking the windows builds
goncaloalmeida
added a commit
that referenced
this pull request
Dec 11, 2023
* Revert "Add gtest to Fetch content #550 (#551)" This reverts commit 70d59ed - breaking the windows builds * Fix CI for Windows builds --------- Co-authored-by: Gonçalo Almeida <[email protected]>
|
This PR was reverted -> not compiling with Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.