Final touch ups #152
Merged
Final touch ups #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juslam19
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final touch ups:
(Most important/ biggest change) Shift code executor
Shifted API call to Judge0 to collaboration service backend, current implementation exposes the API secret. Code is just copied to the backend so this hopefully should not be too dangerous of a change.
Hash OAuth password
Randomly generated OAuth passwords are not hashed currently- simply hash the password before saving to DB.
Add visibility toggle for password field (sign up + login)
Fix question table loading (show 'loading' state while it is loading)
Realised I probably left some in-progress code inside and accidentally committed it so the loading wasn't working properly at all.
Removes mentions of practice room password (since not implementing)