Frontend setup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwokieee
force-pushed
the
frontend-setup
branch
from
c1fc7cb
to
bf792ab
Compare
chownces
suggested changes
Sep 6, 2023
|
|
||
| strategy: | ||
| matrix: | ||
| commands: ['format:ci', 'lint:ci', build] |
There was a problem hiding this comment.
Should we include the test command in the CI?
frontend/.husky/pre-commit
Outdated
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| cd frontend; yarn format; |
There was a problem hiding this comment.
Should we add yarn test to the pre-commit hook?
frontend/package.json
Outdated
Comment on lines
9
to
10
| "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0", | ||
| "lint:ci": "eslint \"{src,apps,libs,test}/**/*.ts\"", |
There was a problem hiding this comment.
Similar commands here. The backend uses lint:ci since lint had a auto --fix option.
chownces
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend setup using Vite and React