Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
Create main.yml
* Add cors * Update default value for code editor * Remove console log
* Add timer to matching service popup * Update CustomCircularProgress.tsx * Update index.tsx * Update styling of circular progress to ensure it is consistent with the color theme and size --------- Co-authored-by: Kang-Quan <[email protected]>
* Remove dead code * Fix overflow for code editor
* fix healthcheck bug * add logging for matching service and matching worker service * uncomment service
* Add matching-service and rabbitmq configs * Add matching-worker-service configs and other services for k8 * Update matching-service configurations for k8 * Update ingress * Update Server-Configs * Add prod configMaps * Update k8 ingress * Add more services for k8 prod * Update kustomization.yaml for k8 prod * Add prometheus to k8 prod * Update k8 * Update resource consumed by all services in k8 prod * Update resources used in k8 prod * Update mongodb URI and postgres URI * Update DNS URIs * Add service for ingress * Update docker compose files * Update nginx-ingress-prod.yaml --------- Co-authored-by: Kang-Quan <[email protected]>
Co-authored-by: Zenith Yap <[email protected]>
Co-authored-by: Zenith Yap <[email protected]>
* Add health check endpoint for question service * Add health check endpoint for profile service --------- Co-authored-by: Zenith Yap <[email protected]>
* Update URLs * Update routes * Add comments * Remove strings * Update network * Update mongodb * Update live routes * Add dockerfile for production * Update docker compose * Update Readme
* Add routes for google cloud * Add dockerfile for gke * Add github workflow for gke * Change gitlab image name --------- Co-authored-by: Zenith Yap <[email protected]>
Co-authored-by: Zenith Yap <[email protected]>
* Add button to leave room * Add leave room function * Fix leave room function * Add confirmation pop up for leaving room * Informs other user if client has disconnected * Change naming convention * Fix bug where user cannot connect again --------- Co-authored-by: Zenith Yap <[email protected]> Co-authored-by: Kang-Quan <[email protected]>
Co-authored-by: Zenith Yap <[email protected]>
* Fix selection of question from questions page * Add spacing for categories * Remove chip background when no questions * Remove redundant comments --------- Co-authored-by: Zenith Yap <[email protected]>
* Update index.tsx * Update index.tsx
* update documentation * remove indentation
* Add documentation for bollaboration service * Fix indent --------- Co-authored-by: Zenith Yap <[email protected]>
* Enhance code editor to have syntax highlighting for supported languages Enhance code editor to have dark and light theme Enhance code editor to have formatting for javascript using shift+alt+file Enhance code editor to have auto indentation * Add feature to disable changing language when matched * Add styling and fix bug where difficult qn cannot connect
Co-authored-by: Zenith Yap <[email protected]>
* Add documentation for CRUD for profile service * Add docs for admin * Add docs for requesting admin * Add docs for super admin * Add image to docs
* Add project report to codebase * Change file type to words
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @Edfernape @huizhuansam @Acerizm @zenithyap @Kang-Quan