Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
Now correctly checks if individuals are in an active session or not. Also added cron job that checks every hour if rooms are 4 hours old, and sets those rooms to inactive.
include cron job in server.ts
Minor changes made to test termination and status checks
remove irrelevant service
Added authentication to frontend
Some changes and cleanup of the UI
* Poor contrast for (i) icon in light mode * Password validity is not checked if user does not input anything.
…S1/cs3219-ay2425s1-project-g38 into development_branch
Enhance security by repacking JWT with extra fields and signed by frontend
Fix UI bug - wrong error message, does not redirect if token has expired. Include password requirements. Fix session bug - destroys session so link is no longer valid after succesful password reset Email format tells user to use the same browser (else it would not work)
update error message of details endpoint
…S1/cs3219-ay2425s1-project-g38 into development_branch
…S1/cs3219-ay2425s1-project-g38 into development_branch
Now terminates room if only one user is in the session
…S1/cs3219-ay2425s1-project-g38 into development_branch
Milestone 5, 6 and 7
Update README.md
Update docker compose
Update docker compose to seperate frontend
now displays correct message when only one user is in the session.
fix termination description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @delishad21 @jayllo-c @Jweng88 @dloh2236