Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend restructuring #15

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

delishad21
Copy link
Collaborator

@delishad21 delishad21 commented Oct 8, 2024

  1. Removed questions-management/list and made it the main page for the questions-management directory (this is just cleaner i think)
  2. Remove the concatenation of Question List in the sidebar in components/sidebar.tsx (not too sure why it was implemented this way but all pages included in sidebar are are now all collected under config/site.ts)
  3. Implemented logic for sidebar to highlight the page that is selected. (This includes subpages e.g. questions-management/edit will still cause Question Management to be highlighted)
  4. Moved all current pages into the app/(default) folder. (This has no effect on the URL, it just allows for multiple root layouts) - Can read on NextJS Route Groups to find out more abt this
  5. Created a new directory app/(landing) for landing and login page (the root layout for the "(landing)" directory does not include the navbar and sidebar)

@delishad21 delishad21 merged commit c6450e1 into development_branch Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant