-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KP-9173 Use the backend of this particular instance #9
base: config/master
Are you sure you want to change the base?
Conversation
To enable multiple instances under kielipankki.fi, instead of always using the production backend, use whatever backend the URL suggests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think this is a change required for Korp test instances to work in the new environment.
(Sorry about the changes in the comments; I haven’t used GitHub’s reviewing features before, so I didn’t get it right the first time and I don’t know if this is right, either.)
No, great, thanks for reviewing, it was obviously very useful in this case! One useful feature here is the ability to directly suggest a code change. In the comment box for a particular line of code, one of the icons you can hover over is "suggest change", and if you click it, it fills in a template with the old line, and you can write in your suggested improvement. |
Good! And thanks for the hint; that sounds very useful. |
This also enforces https in a few other URLs.
To enable multiple instances under kielipankki.fi, instead of always using the production backend, use whatever backend the URL suggests.