Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KP-9173 Use the backend of this particular instance #9

Open
wants to merge 3 commits into
base: config/master
Choose a base branch
from

Conversation

Traubert
Copy link

To enable multiple instances under kielipankki.fi, instead of always using the production backend, use whatever backend the URL suggests.

To enable multiple instances under kielipankki.fi, instead of always
using the production backend, use whatever backend the URL suggests.
app/config.js Outdated Show resolved Hide resolved
Copy link

@janiemi janiemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think this is a change required for Korp test instances to work in the new environment.

(Sorry about the changes in the comments; I haven’t used GitHub’s reviewing features before, so I didn’t get it right the first time and I don’t know if this is right, either.)

@Traubert
Copy link
Author

(Sorry about the changes in the comments; I haven’t used GitHub’s reviewing features before, so I didn’t get it right the first time and I don’t know if this is right, either.)

No, great, thanks for reviewing, it was obviously very useful in this case!

One useful feature here is the ability to directly suggest a code change. In the comment box for a particular line of code, one of the icons you can hover over is "suggest change", and if you click it, it fills in a template with the old line, and you can write in your suggested improvement.

@janiemi
Copy link

janiemi commented Nov 18, 2024

Good! And thanks for the hint; that sounds very useful.

app/config.js Outdated Show resolved Hide resolved
This also enforces https in a few other URLs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants