Update the dependencies (and sort out the resulting mess) #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
History is required by revision date plugin
joonas-somero
added
the
on hold
|
I suppose this should wait for Preview to support the new dependencies. |
Also, take the opportunity to move them into Allas
E.g. when building locally with Podman or Docker
lvarin
reviewed
Sep 13, 2024
Dockerfile
Outdated
Comment on lines
30
to
40
| RUN if [ ! -d ".git" ]; then \ | ||
| git clone --no-checkout https://github.com/$repo_org/$repo_name git_folder && \ | ||
| mv git_folder/.git . && \ | ||
| rm -r git_folder && \ | ||
| git reset HEAD --hard && \ | ||
| git checkout -f $repo_branch | ||
| git checkout -f $repo_branch; fi | ||
|
|
||
| RUN pip3 install --no-cache-dir -r requirements.txt && \ | ||
| bash scripts/generate_alpha.sh && \ | ||
| RUN bash scripts/generate_alpha.sh && \ | ||
| bash scripts/generate_by_system.sh && \ | ||
| bash scripts/generate_new.sh && \ | ||
| bash scripts/generate_glossary.sh && \ |
There was a problem hiding this comment.
Why not join these two RUNs?
If they are joined and the .git directory is deleted as a last step, there will be only one layer and it will be smaller.
There was a problem hiding this comment.
I've now joined them. For getting the missing .git directory, I was thinking
RUN if [ ! -d ".git" ]; then \
git clone --bare https://github.com/$repo_org/$repo_name .git && \
git init && \
git switch --force $repo_branch; fi && \
bash scripts/generate_alpha.sh && \
bash scripts/generate_by_system.sh && \
bash scripts/generate_new.sh && \
bash scripts/generate_glossary.sh && \
mkdocs build -d /usr/share/nginx/htmlI don't know if it's any quicker, but it is more readable.
|
I checked the changes but not the CSS, because I do not know enough. Maybe @jemaltahir can comment on those changes. Looks good to me, only the small comment about the |
|
I am reviewing the CSS part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Title.
Deployed at https://demo-sidebars-docs-csc-development.2.rahtiapp.fi/ (fork)
TODO: