CSCEXAM-1215 Changes to question editor #1007
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupari
reviewed
Oct 12, 2023
| @@ -87,6 +87,14 @@ export class LibraryResultsComponent implements OnInit, OnChanges { | |||
| this.selected.emit(selections); | |||
| }; | |||
|
|
|||
| calculateExams = (question: LibraryQuestion): number => { | |||
There was a problem hiding this comment.
Saisko tän vähän lyhennettyä? Esim
question.examSectionQuestions.map(esq => esq.examSection.name).length tjsp.
There was a problem hiding this comment.
Itseasiassa tuossahan on turhaa kaikki paitsi viimeinen rivi?
lupari
reviewed
Oct 12, 2023
| @@ -171,6 +172,8 @@ export class ExamQuestionComponent implements OnInit { | |||
| .map((optionType) => this.Question.getOptionTypeTranslation(optionType)); | |||
| }; | |||
|
|
|||
| sortByString = (prop: string[]): Array<string> => prop.sort(); | |||
There was a problem hiding this comment.
Array<string> => string[] ?
lupari
approved these changes
Oct 12, 2023
lupari
reviewed
Oct 13, 2023
| <div class="col warning-text" *ngIf="examNames.length > 1"> | ||
| {{ 'sitnet_exam_question_edit_instructions_more_than_one' | translate }} | ||
| </div> | ||
| <div class="col warning-text" *ngIf="examNames.length == 1"> |
lupari
requested changes
Oct 13, 2023
| @@ -87,6 +87,14 @@ export class LibraryResultsComponent implements OnInit, OnChanges { | |||
| this.selected.emit(selections); | |||
| }; | |||
|
|
|||
| calculateExams = (question: LibraryQuestion): number => { | |||
There was a problem hiding this comment.
Itseasiassa tuossahan on turhaa kaikki paitsi viimeinen rivi?
lupari
reviewed
Oct 13, 2023
| @@ -75,6 +76,8 @@ export class QuestionBodyComponent implements OnInit { | |||
|
|
|||
| showWarning = () => this.examNames.length > 1; | |||
|
|
|||
| sortByString = (prop: string[]): Array<string> => prop.sort(); | |||
There was a problem hiding this comment.
Array<string> => string[] ?
VirmasaloA
changed the title
|
Ei taida olla enää validi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.