CSCEXAM-1163 Fix examination question hide button accessibility #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Poistin samalla parista muustakin kohtaa ylimääräsiä alt atribuutteja. |
VirmasaloA
force-pushed
the
CSCEXAM-1163-2
branch
from
900cc93
to
56e91af
Compare
lupari
requested changes
Sep 13, 2024
| @@ -71,6 +71,11 @@ export class ExaminationQuestionComponent implements OnInit, AfterViewInit { | |||
| const { answer } = this.sq.clozeTestAnswer; | |||
| this.clozeAnswer = JSON.parse(answer); | |||
| } | |||
| this.questionTitle = this.removeParagraphTags(this.sq.question.question); | |||
There was a problem hiding this comment.
Mikäs tämä juttu on?
Ah ok joku nappulan aria-teksti. Voisko sen koko tekstin vaikka laittaa funktion sisään ettei tuonne templaattiin tarvitse noin paljon stringi-manipulaatiota pistää? (katso ylempi kommentti=
| <button | ||
| tabindex="0" | ||
| class="pointer section-box-title arrow border-none background-none" | ||
| [attr.aria-label]=" |
There was a problem hiding this comment.
Voisko tämän labelin generoinnin laittaa omaan funtioonsa? Nyt näyttää aika sekavalta näin templaatissa.
VirmasaloA
force-pushed
the
CSCEXAM-1163-2
branch
from
2a30912
to
02c4fe4
Compare
lupari
requested changes
Sep 24, 2024
|
|
||
| parseAriaLabel(expanded: string): string { | ||
| return ( | ||
| this.translate?.instant(expanded) + |
There was a problem hiding this comment.
Voisko käyttää templaatti-stringiä mielummin? Eli ``-syntaksia?
VirmasaloA
force-pushed
the
CSCEXAM-1163-2
branch
from
cca43ca
to
fba3fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.