CSCEXAM-1356 Add shortens to exam list #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirmasaloA
force-pushed
the
CSCEXAM-1356
branch
from
c82d809
to
0e2e344
Compare
lupari
reviewed
Oct 23, 2024
| @@ -22,6 +22,7 @@ export class TableSortComponent { | |||
| @Input() predicate = ''; | |||
| @Input() text = ''; | |||
| @Input() reverse = false; | |||
| @Input() sliced: boolean | string = false; | |||
|
|
|||
| getSortClass = () => | |||
There was a problem hiding this comment.
Miksi tämä on jompaa kumpaa tyyppiä?
There was a problem hiding this comment.
Miulla se typescript kieltäyty buildaamasta pelkällä booleanilla. Tää ei oo hyvä ratkasu, mut sillä se buildas.
HTML filussa oli insert sliced="{{true}}" ja typescript ei hyväksyny sitä booleaniks..
lupari
reviewed
Oct 23, 2024
| @@ -38,6 +38,7 @@ | |||
| <xm-table-sort | |||
| by="course.code" | |||
| text="i18n_course_code" | |||
| sliced="{{ true }}" | |||
lupari
requested changes
Oct 23, 2024
VirmasaloA
force-pushed
the
CSCEXAM-1356
branch
from
91a3ef7
to
4524d82
Compare
lupari
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.