Updates Hedgedoc CSC Helm Chart: #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `README` - Update `Chart.yaml` version - Update `values.yaml` - `postgresql.enabled=false` by default - `postgresqlExternal.enabled=true` by default - `ClusterIP` service by default for Hedgedoc - Update `secrets.yaml` to reflect if we deploy an external database or not. - Update `values.schema.json` - Add comments/explanations in `values.yaml`
lvarin
reviewed
Oct 3, 2024
charts/hedgedoc/README.md
Outdated
|
|
||
| ### PostgreSQL parameters | ||
|
|
||
| Since we are using the `bitnami/postgresql` Helm Chart as a dependency, you can take a look to the [PostgreSQL ArtifactHub](https://artifacthub.io/packages/helm/bitnami/postgresql/15.5.0) to check the different values. | ||
|
|
||
| The postgres database password is generated randomly and won't change if you upgrade the Chart. | ||
| This parameters is disabled by default. If you want to use a postgresql database among, enable it with `postgresql.enabled` |
There was a problem hiding this comment.
Small grammar mistake. It is either These parameters or This parameter
lvarin
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.10.0READMEChart.yamlversionvalues.yamlpostgresql.enabled=falseby defaultpostgresqlExternal.enabled=trueby defaultClusterIPservice by default for Hedgedocsecrets.yamlto reflect if we deploy an external database or not.values.schema.jsonvalues.yaml