Cscfc4 emscr 591 remove file upload from add revision modal for mscr format #230
Conversation
…dd-Revision-Modal-for-MSCR-Format
…dd-Revision-Modal-for-MSCR-Format
| @@ -108,12 +111,12 @@ export default function FormModal({ | |||
| usePutSchemaMscrCopyMutation(); | |||
| const [submitAnimationVisible, setSubmitAnimationVisible] = | |||
| useState<boolean>(false); | |||
|
|
|||
| const formDataFromInitialData = useCallback(() => { | ||
| if (!initialData) return; | ||
| const existingData: FormType = { | ||
| format: | ||
| modalType == ModalType.MscrCopy ? Format.Mscr : initialData.format, | ||
| modalType == ModalType.MscrCopy? Format.Mscr : initialData.format, |
There was a problem hiding this comment.
There should be a space between the conditional operators and the operands, so restore space between 'ModalType.MscrCopy' and '?'
| @@ -352,6 +364,7 @@ export default function FormModal({ | |||
| } else if (formData.format !== Format.Mscr) { | |||
| return; | |||
| } | |||
|
|
|||
| @@ -363,7 +376,7 @@ export default function FormModal({ | |||
| setSubmitAnimationVisible(false); | |||
| } | |||
| ); | |||
| } else if (modalType == ModalType.RegisterNewMscr) { | |||
| } else if (modalType == ModalType.RegisterNewMscr) {//what is register new MSCR? | |||
There was a problem hiding this comment.
If you look at the definition of the ModalType:
export enum ModalType {
RegisterNewFull = 'REGISTER_NEW_FULL',
RegisterNewMscr = 'REGISTER_NEW_MSCR',
RevisionFull = 'REVISION_FULL',
RevisionMscr = 'REVISION_MSCR',
MscrCopy = 'MSCR_COPY',
}
RegisterNewMscr is registering something in MSCR-format, where there's no file sent, as opposed to RegisterNewFull, where there should also be a file attached. In practice it always means creating (and registering) a new crosswalk, since that's always MSCR-format.
There was a problem hiding this comment.
Thanks :) I was wondering what this action :)
| @@ -7,6 +7,7 @@ import { | |||
| formatsAvailableForSchemaRegistration, | |||
| } from '@app/common/interfaces/format.interface'; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Is there a reason for adding extra empty lines?
| @@ -352,15 +352,28 @@ export default function SchemaView({ schemaId }: { schemaId: string }) { | |||
| /> | |||
| )} | |||
| {/*ToDo: When making a revision of an mscr copy is possible, take that into account here (Modaltype.RevisionMscr)*/} | |||
There was a problem hiding this comment.
This ToDo is completed with your changes! :)
If the schema format is MSCR, then the revision creation modal should not have the file upload or URI input box.