Do not enforce representability for hybrid binaries in elf imgact. #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
approved these changes
Jul 10, 2023
|
Use the __ELF_CHERI or whatever ifdef? We compile imgact_elf once for each ELF type. |
qwattash
force-pushed
the
fix-non-cheri-bin-loading
branch
from
58753bd
to
45833e4
Compare
Done |
arichardson
reviewed
Jul 10, 2023
jrtc27
reviewed
Jul 10, 2023
jrtc27
reviewed
Jul 10, 2023
jrtc27
reviewed
Jul 10, 2023
qwattash
force-pushed
the
fix-non-cheri-bin-loading
branch
from
45833e4
to
54b0702
Compare
jrtc27
approved these changes
Jul 11, 2023
|
One nit: s/commont/comment/ in the second log message. |
bsdjhb
approved these changes
Jul 12, 2023
When loading hybrid position-dependent binaries, we do not care about the representability of the ELF sections. The reservation creation will skip the representability alignment enforcement as well, so avoid complaining about alignment when creating the imgact_capability.
qwattash
force-pushed
the
fix-non-cheri-bin-loading
branch
from
54b0702
to
e4387a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading hybrid position-dependent binaries, we do not care about the representability of the ELF sections. The reservation creation will skip the representability alignment enforcement as well, so avoid complaining about alignment when creating the imgact_capability.
This should fix #1700.