caprevoke: actually revoke unmapped entries #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we were in the process of revoking we need to NULL out map->rev_entry so that vm_map_delete() is allowed to unlink the entry. Also zero the stats structure.
I'd put the call to vm_map_entry_end_revocation() at the end of the initial store-side barrier so it somewhat worked, by accident, but was missed more or less completely in the load-side case.
|
These commits are also in #1743, but I want to include them in a pre-load-side removal tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on #1743 I discovered that I was the unmapped entry that was being revoked too early resulting in it never being removed except perhaps in the most accidental fashion. Fixing this turned up a bug when exiting a process that was in the load-side INITED state as we'd hit an assert when trying to unlink the entry being removed.