Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seL4: Add new compilation targets #368

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

seL4: Add new compilation targets #368

wants to merge 2 commits into from
+53 −1

Conversation

heshamelmatary
Copy link
Member

No description provided.

arichardson
arichardson reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the issues I've pointed out have been fixed.

@heshamelmatary
seL4: Add new compilation targets
69fd591
@heshamelmatary
seL4: prefix LLVM's tools with supported seL4 target triples
05d76cd 
Mainly to get binutils symlinked as expected by the seL4's
cmake build system.
@arichardson
Copy link
Member

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

arichardson
arichardson reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you use BaremetalFreestandingTargetInfo for sel4?

@heshamelmatary
Copy link
Member Author

heshamelmatary commented Jul 24, 2023 •
edited
Loading

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

You can actually build compiler-rt-builtins-sel4-morello-aarch64 and compiler-rt-builtins-sel4-riscv64 with this PR. Also if you add -d it will install "-none--" tools symlinks required for building seL4. But there's still no seL4 target build yet, that I may add in the future.

@arichardson
Copy link
Member

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

You can actually build compiler-rt-builtins-sel4-morello-aarch64 and compiler-rt-builtins-sel4-riscv64 with this PR. Also if you add -d it will install "-none--" tools symlinks required for building seL4. But there's still no seL4 target build yet, that I may add in the future.

True, but couldn't you use the generic baremetal compiler-rt target already? Adding the symlinks should also be possible without the new target info

@heshamelmatary
Copy link
Member Author

CI failure looks unrelated. Change looks good to me now, although you aren't actually using it yet.

You can actually build compiler-rt-builtins-sel4-morello-aarch64 and compiler-rt-builtins-sel4-riscv64 with this PR. Also if you add -d it will install "-none--" tools symlinks required for building seL4. But there's still no seL4 target build yet, that I may add in the future.

True, but couldn't you use the generic baremetal compiler-rt target already? Adding the symlinks should also be possible without the new target info

Yeah I could just use baremetal. But some variants may need different flags (e.g., hard-float vs soft-float which is the default for bare metal?) or extensions as well. I am happy to wait for this PR until I decide if it's a good idea to build seL4 projects for cheribuild or not.

@arichardson arichardson marked this pull request as draft July 26, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arichardson arichardson arichardson left review comments

@jrtc27 jrtc27 Awaiting requested review from jrtc27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heshamelmatary @arichardson