-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Morello benchmark ABI kernels. #398
Conversation
401bb19
to
00dfcfb
Compare
Won't this break building older CheriBSD, including in CI for releng/23.11? |
Right.. I wanted to avoid adding another option specifically for benchmark ABI kernels, but maybe I need a different flag to disable building benchmark ABI kernels. I'm leaning towards building it by default but I could make it off-by-default. |
It needs to be off by default unfortunately, and enabled in CheriBSD CI, but we can flip the default once 24.0x is out. |
00dfcfb
to
73deffb
Compare
This version should fix it. It is now enabled with cheribuild/pycheribuild/projects/simple_project.py Lines 981 to 985 in afea91f
|
aa219a9
to
39c3cb8
Compare
This is enabled by the build-benchmark-abi-kernels.
39c3cb8
to
d28a85a
Compare
This is inhibited by the no-build-alternate-abi-kernels.