Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit an error instead of crashing on invalid use of __capability #704

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Emit an error instead of crashing on invalid use of __capability #704

merged 3 commits into from
Jul 6, 2023

Commits on Jul 6, 2023

  1. Emit an error instead of crashing on invalid use of __capability 

    Previously, attempting to generate code that contained __capability while
using a target without support for CHERI would assert with
`Assertion `llvm::isPowerOf2_32(Align) && "Alignment must be power of 2"' failed.`
Fix this by emitting a more user-friendly error message instead of crashing
when we encounter __capability but CHERI is not supported.
Ideally we would not expose the keyword for non-CHERI but that is a
rather more invasive change.
    @arichardson
    arichardson committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e21a407 View commit details
    Browse the repository at this point in the history

  2. Update a test to use -verify instead of checking for "no crash" 

    Also drop the second non-reduced test for the same issue.
    @arichardson
    arichardson committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e2fae40 View commit details
    Browse the repository at this point in the history

  3. Consistently use qualifier to refer to __capability. NFC

    @arichardson
    arichardson committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1f044f6 View commit details
    Browse the repository at this point in the history