[GCAtomic] Treat single capability structs like a capability #724
+375
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://git.morello-project.org/morello/llvm-project/-/issues/75 for Morello, where this is miscompiled to i128 exchanges instead of using libcalls/capabilities.
This shows the undesirable casts to i128. They happen to be benign for the current codegen, but we should be using a capability type for the struct that contains only one capability.
This is duplicated twice in RISCVABIInfo and I intend to reuse this in the following commit.
This allows emitting inline atomics instead of needing a libcall and avoids casting such structs to i128. See https://git.morello-project.org/morello/llvm-project/-/issues/75
|
@jrtc27 ping. Does this look sensible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows emitting inline atomics instead of needing a libcall and
avoids casting such structs to i128.
See https://git.morello-project.org/morello/llvm-project/-/issues/75