Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHERI] Remove DEBUG_CAP_(RELOCS/TABLE) options #746

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[CHERI] Remove DEBUG_CAP_(RELOCS/TABLE) options #746

wants to merge 1 commit into from
+0 −34

Conversation

veselypeta
Copy link

@veselypeta veselypeta commented Jul 11, 2024 •
edited
Loading

This PR:

  • Fixes the build for when DEBUG_CAP_RELOCS or DEBUG_CAP_TABLE is defined.
  • Removes the DEBUG_CAP_RELOCS and DEBUG_CAP_TABLE options

arichardson
arichardson approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how useful this code is still, but fixing it definitely makes sense. Maybe we should just delete it?

@jrtc27
Copy link
Member

jrtc27 commented Jul 29, 2024

I'd be pro deleting it; compile-time configuration is generally unhelpful. That or LLVM_DBG-ify it (or similar) if it's really that useful, but given it's been unused for who knows how long...

@veselypeta veselypeta changed the title [CHERI] Fix DEBUG_CAP_(RELOCS/TABLE) build [CHERI] Remove DEBUG_CAP_(RELOCS/TABLE) options Jul 30, 2024
@arichardson
Copy link
Member

Will merge this once we have llvm-16 in dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arichardson arichardson arichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veselypeta @jrtc27 @arichardson