Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

feat: collect new UI events #116

Merged
merged 4 commits into from
Dec 17, 2020
Merged

feat: collect new UI events #116

merged 4 commits into from
Dec 17, 2020

Conversation

BumbleFlash
Copy link

@BumbleFlash BumbleFlash commented Dec 14, 2020

This PR is to capture the next set of UI_EVENTS as listed in #17.

Changes:-

  • PLAY_NEXT, PLAY_ALBUM_ARTIST_NEXT, PLAY_ALBUM_NEXT and PLAY_GENRE_NEXT.
  • ADD_TO_PLAYLIST, ADD_TO_PLAYLIST_ALBUM_ARTIST, ADD_TO_PLAYLIST_ALBUM and ADD_TO_PLAYLIST_GENRE
  • DELETE, DELETE_ALBUM_ARTIST, and DELETE_ALBUM
  • ALBUM_SHUFFLE
    - [ ] BLACKLISTS

@BumbleFlash BumbleFlash requested a review from barbeau December 14, 2020 16:43
@barbeau
Copy link
Member

barbeau commented Dec 14, 2020

@BumbleFlash Before adding any tracking for the current BLACKLISTS features let's address #114 and #115 (including renaming to "Disable").

@barbeau
Copy link
Member

barbeau commented Dec 16, 2020

@BumbleFlash Is this ready for review or still waiting on the shuffle implementation?

@BumbleFlash BumbleFlash marked this pull request as ready for review December 17, 2020 14:51
@BumbleFlash
Copy link
Author

@barbeau I just pushed a commit to capture the ALBUM_SHUFFLE event. And yes, it's ready for review!

Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @BumbleFlash! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants