build: run dump_symbols in CMAKE_SOURCE_DIR #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincele
reviewed
Dec 18, 2024
| @@ -35,6 +35,7 @@ execute_process( | |||
| ${Python_EXECUTABLE} | |||
| dump_symbols.py | |||
| "${occt_libs}" | |||
| WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} | |||
There was a problem hiding this comment.
I am trying to package cadquery for guix.
I had the same fix / workaround, until I tried to only change line 36, to the following
${CMAKE_SOURCE_DIR}/dump_symbols.py
which also "fixed" it for me. I don't know which one is the better "fix"
But I'm here to add my 👍
|
It will be reviewed eventually. For packaging please use the released sources in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dump symbols should be run within the
CMAKE_SOURCE_DIR. If cmake tries to run it with a different working directory it fails to find the script and generates output in the wrong place.