NAudio support #491
NAudio support #491
Conversation
Add NAudio with NVorbis support for better song waveform manipulation and improved delays.
| SongAudioSource.Play(); | ||
| //ELECAST TEST SongAudioSource.time = CurrentSeconds; | ||
| //ELECAST TEST SongAudioSource.Play(); | ||
| SetVorbisPosition((long)(CurrentSeconds * bytesPerSecond));//ELECAST TEST |
There was a problem hiding this comment.
seeking based on byte position instead of time might be inaccurate with variable bitrates
is there no way to seek based on time?
There was a problem hiding this comment.
variable bitrates is not a problem since bytesPerSecond is obtained when we load the song file, or do you mean something else? I couldn't find a way to seek based on time
There was a problem hiding this comment.
bitrate can vary throughout one file, not just between different files
by basing on the average bitrate, you can end up seeking to the wrong time
There was a problem hiding this comment.
Oh that makes sense, will check into that
|
I'm concerned about how this will impact hitsound/metronome synchronization. It might be necessary to handle those through NAudio as well |
Eventually the best would be to handle all through NAudio, it will require to write a mixer from scratch tho. Still I think it is more important to find a way to make song speed work before doing all of that. |
Add NAudio with NVorbis support for better song waveform manipulation and improved delays.
TO DO:
Important changes are in AudioTimeSyncController.cs and SongTimelineController.cs, Everything else is from Plugins