Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Intern Property instances so reference equality is guaranteed #22

Open
wants to merge 9 commits into
base: 1.16.x
Choose a base branch
from
Open

Intern Property instances so reference equality is guaranteed #22

wants to merge 9 commits into from

Commits on Feb 7, 2021

  1. Add caching of BooleanProperty instances 

    Uses WeakReferences, so properties can be GC'd if necessary
    @magneticflux-
    magneticflux- committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    6e9cbcf View commit details
    Browse the repository at this point in the history

  2. Major refactor to use WeakHashMap and MapKeyGetter instead of Finaliz… 

    …ableWeakReferenceToCachedProperty

This allows mixins into Direction and Integer properties as well
    @magneticflux-
    magneticflux- committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    74619fb View commit details
    Browse the repository at this point in the history

  3. Remove unused parameters from mixins

    @magneticflux-
    magneticflux- committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    ba8ed39 View commit details
    Browse the repository at this point in the history

  4. Document WeakPropertyCache

    @magneticflux-
    magneticflux- committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    d1b6971 View commit details
    Browse the repository at this point in the history

  5. Remove dev logging

    @magneticflux-
    magneticflux- committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    e55c756 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. Use a WeakReference as the cache map value instead of using MapKeyGetter 

    Co-authored-by: 2No2Name <[email protected]>
    @magneticflux- @2No2Name
    magneticflux- and 2No2Name committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    a339aee View commit details
    Browse the repository at this point in the history

  2. Make and check a defensive copy of the cached property 

    This prevents the GC from clearing the weak reference before we access it strongly
    @magneticflux-
    magneticflux- committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    7603673 View commit details
    Browse the repository at this point in the history

  3. Re-add synchronized block on CACHE

    @magneticflux-
    magneticflux- committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3f02c6f View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Add missing EnumProperty mixin

    @magneticflux-
    magneticflux- committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    f4a33fd View commit details
    Browse the repository at this point in the history