Optimized explosion entity exposure calculations #507
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request comprises three optimizations:
Explosion#getExposure
calls.Since these optimizations specifically target entity-related explosion calculations, they have virtually no effect on single explosions. Chained explosions, however, see massive benefits due to the creation of dropped items & exp orbs which are then affected by the subsequent explosions.
I'm not particularly good at documentation, so suggestions are welcome.
Benchmarks
~150% improvement in time spent exploding 4096 tnts.
Benchmarked using seed
-3199243952349285632
(randomly chosen) and 4096 tnt (/fill ~1 ~-7 ~ ~16 ~8 ~15 tnt
)Before:
9492 ms spent in
World.createExplosion()
Spark profileAfter:
3832 ms spent in
World.createExplosion()
Spark profile