fix: use dimension type from constructor instead of calling getDimension
#510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a mod compat issue from a mod overriding
getDimension
in its ownWorld
subclass and returning a value from a field it initialized in the subclass constructor. Since Lithium's inject runs before the subclass constructor, this caused an NPE.The best solution IMO is to just use the dimension type provided as the constructor argument, rather than retrieving it through
getDimension
. This changes nothing for vanilla behavior because the default implementation ofWorld#getDimension()
returns a field initialized by that argument.