Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when NPOT textures are preventing the use of mip-mapping #2644

Open
TheNukeLore opened this issue Aug 7, 2024 · 5 comments
Open
Labels
F-good-first-issue Flag: Good first issue for new contributors S-accepted Status: Request accepted but needs volunteer T-enhancement Type: Enhancement

Comments

@TheNukeLore
Copy link

TheNukeLore commented Aug 7, 2024

Request Description

When resourcepacks or mods use non-power of two textures, it will drop down the mipmapping level, respectively. However, the only warning is a small warning in the log files; however, this greatly affects the visuals of the game.
I request that sodium could do a few potential things, or potentially all:

  • Gray out the mipmapping setting in the video settings alongside a description of why this has happened via a tooltip
  • Give a warning toast similar to the existing warning toasts sodium has regarding core-shaders

Should probably list out the packs and textures causing said issues as well.

@TheNukeLore TheNukeLore added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels Aug 7, 2024
@jellysquid3
Copy link
Member

Note: I've been told that NeoForge (at least on 1.21?) actually allows NPOT textures to be used, even though it cannot correctly generate mipmaps for them. So we may want to do this only on Fabric for the time being.

@jellysquid3 jellysquid3 added F-good-first-issue Flag: Good first issue for new contributors and removed S-needs-triage Status: Needs triage labels Aug 7, 2024
@jellysquid3 jellysquid3 changed the title Add Mipmap Warning. Show warning when NPOT textures are preventing the use of mip-mapping Aug 7, 2024
@jellysquid3 jellysquid3 added the S-accepted Status: Request accepted but needs volunteer label Aug 7, 2024
@djmrFunnyMan
Copy link

I'd support replacing any npot textures with the missing texture to force ppl to make their damn texture packs correctly

@jellysquid3
Copy link
Member

Users don't have any choice in what nonsense their resource packs (or mods) are doing. The most that I'm comfortable with doing is showing a warning similar to the other ones that exist for incompatible resource packs, so that users know why there are problems.

@MeeniMc
Copy link
Contributor

MeeniMc commented Aug 9, 2024

npot assets are already listed in the log (they also ''work as intended'' on fabric, but mip-mapping is broken globally). However the assets are not linked to the resource pack of origin (would be great to know, not always obvious otherwise)

@djmrFunnyMan
Copy link

The warning is a good idea. Imo it should also appear after loading in because it's likely people already had the texture packs selected since long ago. The on-load warning should also identify any mods with bad textures and nicely list them for the player (but clearly list out texturepacks and mods separately for user convinience). A small note saying "Please report these issues to the owners of affected mods/texturepacks" so that'll hopefully bring about more pressure to fix those things.

The on-load warning should have a "don't show this again" checkbox, so that it doesn't get annoying.

Also with the warning there should be a small image showing the difference between disabled/enabled mipmapping so users know what they're missing out on (pick out the worst case scenario for mipmaps off like leaves). Majority of players do not know what a "mipmapping" is
Something like this:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-good-first-issue Flag: Good first issue for new contributors S-accepted Status: Request accepted but needs volunteer T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants