Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom particles from Polytone are not animated #2740

Open
MehVahdJukaar opened this issue Sep 9, 2024 · 7 comments
Open

Custom particles from Polytone are not animated #2740

MehVahdJukaar opened this issue Sep 9, 2024 · 7 comments
Labels
S-cannot-repro Status: Developer can't reproduce T-bug Type: Bug

Comments

@MehVahdJukaar
Copy link

Bug Description

Due to some reports that was sent to me, I noticed that people animated particle textures were not animating when sodium was on.
Animation is a normal texture atlas .mcmeta driven texture loop animation.

Now these particles were added via Polytone but the mod itself just registers them to the vanilla registries and sets them up just like ones registered on mod boot, most importantly it doesnt touch stuff related to how the actual particle texture atlas is handled.

I did not look into this further.

Reproduction Steps

Add a particle with Polytone and give it an animated texture. Texture will not be animated on the particle atlas.

Log File

2024-09-09-1.log

Crash Report

2024-09-09-1.log

@MehVahdJukaar MehVahdJukaar added the S-needs-triage Status: Needs triage label Sep 9, 2024
@douira
Copy link
Collaborator

douira commented Sep 9, 2024

Potentially related to #2722?

@jellysquid3
Copy link
Member

We're still in the process of determining the root cause of the problem. Some progress was made the other day, in which we identified some mods had broken resource reload listeners, that were causing problems with sprite finding in Sodium.

@jellysquid3
Copy link
Member

jellysquid3 commented Sep 9, 2024

This change might resolve the issue. Can you see if the nightly build works?

@MehVahdJukaar
Copy link
Author

i'll try

@jellysquid3 jellysquid3 added T-bug Type: Bug and removed S-needs-triage Status: Needs triage labels Sep 9, 2024
@MehVahdJukaar
Copy link
Author

Issue seems to persist with that too

@jellysquid3 jellysquid3 added the S-cannot-repro Status: Developer can't reproduce label Sep 22, 2024
@jellysquid3 jellysquid3 changed the title Broken particle animated textures Custom particles from Polytone are not animated Sep 24, 2024
@jellysquid3
Copy link
Member

I do not understand what the issue would be here, and cannot reproduce it. Your mod does not do anything strange and it successfully hits the code path which marks the texture for being animated.

@MehVahdJukaar
Copy link
Author

Yeah that's the thing me neither. It's just some textures on the particle atlas like all the others. I'll try the new nightly build if there's one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-cannot-repro Status: Developer can't reproduce T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants