Draft: Color picker cursor not restricted to bounds #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When picking a color in the Devices tab, the mouse cursor doesn't need to be strictly in the rectangle and circle bounds anymore
CalcProgrammer1
force-pushed
the
master
branch
from
adf9abb
to
0b787eb
Compare
|
ColorWheel originally came from this project: https://github.com/liuyanghejerry/Qt-Plus I'm not fond of changing dependencies without updating the upstream, but since this hasn't been updated in 10 years maybe it's OK. I would still probably submit a PR against that repo to give upstream the chance to take the fix. |
|
Will do, I'll open a pr for that repo to hopefully get it merged |
|
It seems like my pr on the Qt-Plus repo isn't really about to get pushed after more than 2 months. I don't know if there's gonna be updates on this particular dependency other than upstream |
CalcProgrammer1
force-pushed
the
master
branch
2 times, most recently
from
ca2ffa6
to
52eda68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When picking a color in the Devices tab, the mouse cursor doesn't need to be strictly in the rectangle and circle bounds anymore.
It can be useful to pick edge colors or to pick a hue in the color circle without having to follow strictly the bounds.
A small QOL improvement