Rules should be able to take arrays in the hash conditions #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Updated property matcher to be able to take multiple values
|
@krzyczak Can you create a issue with some description ? |
klobuczek
reviewed
Feb 7, 2023
| @@ -44,7 +44,11 @@ def self.property_matches?(subject, property, value) | |||
| if subject.is_a?(ActiveGraph::Node::HasN::AssociationProxy) | |||
| subject.where(property => value).exists? | |||
| else | |||
| subject.send(property) == value | |||
| if value.is_a?(Enumerable) | |||
| subject.class.where(property => value, neo_id: subject.neo_id).exists? | |||
There was a problem hiding this comment.
if this line is correct then it should handle both cases without the if statement. However, all 10 lines look dubious. If the subject is not a ..Proxy then one should be created rather than querying by neo_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.