fix(axis) - Fixes the axis overlapping, changed the way the markers/label appear to realign on ChartJS design #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-NRCan
commented
Sep 30, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jolevesq)
- Disable thumb swapping on the X slider (native Slider attribute)
Alex-NRCan
commented
Oct 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
Alex-NRCan
force-pushed
the
fix-sliders
branch
from
483071a
to
665d171
Compare
jolevesq
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Reviewed 3 of 6 files at r1, 1 of 1 files at r3, 1 of 2 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:
github-actions bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
fix(axis) - Fixes the axis overlapping, changed the way the markers/label appear to realign on ChartJS design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For best results, the follwoing GeoView code PR has to be merged in the core first!
Canadian-Geospatial-Platform/geoview#2528
Hosted here Oct. 2nd @ 11h00 : https://alex-nrcan.github.io/geochart/
This change is