Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinates data block #104

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Add coordinates data block #104

merged 5 commits into from
Jun 6, 2024

Conversation

EliasJRH
Copy link
Contributor

@EliasJRH EliasJRH commented Jun 6, 2024

This PR adds the implementation of the coordinates data block and its test. It also adds the test for the humidity data block and organizes the data block class so the order of the classes matches the order of everything else

@EliasJRH EliasJRH requested a review from linguini1 June 6, 2024 14:20
Copy link
Collaborator

@linguini1 linguini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add a test case for the Coordinate DB though? There are example packets in the TestWithVoltage mission file.

@EliasJRH
Copy link
Contributor Author

EliasJRH commented Jun 6, 2024

/

Looks good, can you add a test case for the Coordinate DB though? There are example packets in the TestWithVoltage mission file.

Yep! I added them above the voltage db tests

Copy link
Collaborator

@linguini1 linguini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am blind.

@linguini1 linguini1 merged commit 55ab33a into main Jun 6, 2024
4 checks passed
@linguini1 linguini1 deleted the coordinate-db branch June 6, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants