try unit conversion instead of literal dimensionality check #99 #101
Conversation
|
Actually I was just thinking if you wanted me to write a test that check that the context actually works. |
Added tests for the context functionalityIn test_helper.py
Coverage XML written to file coverage.xml ======================================== 206 passed, 2 xfailed, 16 warnings in 6.92s ========================================= |
tests/test_helper.py
Outdated
| class TestContextHandling(TestCase): | ||
| def setUp(self): |
There was a problem hiding this comment.
I know the other lack it as well but could you add some doc string explaining why the test are needed?
May also refer to the isseue?
|
LGTM beside the missing docstring for the test. Now I think I understood what is happing. |
Closes #99.
No extra test needed, coverage remained the same.
py38-django32: OK (38.93=setup[23.56]+cmd[15.37] seconds)
py39-django32: OK (41.60=setup[31.53]+cmd[10.07] seconds)
py310-django32: OK (42.34=setup[30.75]+cmd[11.59] seconds)
py311-django32: OK (41.89=setup[31.09]+cmd[10.80] seconds)
py38-django42: OK (47.90=setup[31.02]+cmd[16.88] seconds)
py39-django42: OK (41.26=setup[30.63]+cmd[10.63] seconds)
py310-django42: OK (42.95=setup[31.91]+cmd[11.04] seconds)
py311-django42: OK (40.84=setup[30.06]+cmd[10.78] seconds)
congratulations :) (337.97 seconds)